This repository has been archived by the owner on May 12, 2021. It is now read-only.
kata-deploy: Check crio conf before update #334
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krsna1729
reviewed
Feb 17, 2019
|
I am fine eitherways. Don't have much of a preference. Anyone from the core team have any preference? Am leaning towards what @krsna1729 is suggesting also cause of less escapes. |
|
I vote for the simpler option with less escapes - it's clearer, so easier to understand and maintain. |
|
simpler, cleaner is always better :-) |
kata-deploy inserts 'manage_network_ns_lifecycle' into crio.conf without any prior checks and if there is a previous entry in the file, this becomes a duplicate causing crio service restart issues. This patch addresses that particular scenario. Signed-off-by: Ganesh Maharaj Mahalingam <ganesh.mahalingam@intel.com>
ganeshmaharaj
force-pushed
the
crio-conf-fix
branch
from
1ef531d
to
059b48b
Compare
|
@jodh-intel @krsna1729 @grahamwhaley thanks for the inputs. new patch up for review. |
krsna1729
approved these changes
Feb 18, 2019
chavafg
approved these changes
Feb 18, 2019
grahamwhaley
approved these changes
Feb 19, 2019
|
/test |
sboeuf
approved these changes
Feb 19, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
kata-deploy inserts 'manage_network_ns_lifecycle' into crio.conf without any
prior checks and if there is a previous entry in the file, this becomes a
duplicate causing crio service restart issues. This patch addresses that
particular scenario.
Signed-off-by: Ganesh Maharaj Mahalingam ganesh.mahalingam@intel.com