This repository has been archived by the owner on May 12, 2021. It is now read-only.
docs: Fix spelling and formatting #542
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
31 tasks
|
|
||
|
|
||
| ### Install Kata and configure Docker | ||
|
|
||
| To install: | ||
|
|
||
| ``` | ||
| docker run -v /opt/kata:/opt/kata -v /var/run/dbus:/var/run/dbus -v /run/systemd:/run/systemd -v /etc/docker:/etc/docker -it katadocker/kata-deploy kata-deploy-docker install |
There was a problem hiding this comment.
could sh ize the block type..
There was a problem hiding this comment.
Agreed - fixed (also yaml blocks).
|
|
||
| The path to the runtime provided by the Kata Containers snap image is | ||
| `/snap/kata-containers/current/usr/bin/kata-runtime`. You should use it to | ||
| run Kata Containers with [docker][9] and [kubernetes][10]. | ||
| run Kata Containers with [docker][9] and [Kubernetes][10]. | ||
|
|
||
| ## Remove snap |
There was a problem hiding this comment.
You capitalised the toc, do you need to match the section header (and maybe any of the body) here?
Whilst here, afaict Ubuntu never capitalise 'snap' ?
There was a problem hiding this comment.
I don't follow? This section heading does match the toc (which I actually lower-cased)...?
There was a problem hiding this comment.
ay, yep, I read the patch backwards ;-) np
devimc
approved these changes
May 24, 2019
|
/test |
GabyCT
approved these changes
May 27, 2019
Correct typos and resolve formatting issues including incorrect heading levels and missing TOC entries. Fixes: kata-containers#541. Signed-off-by: James O. D. Hunt <james.o.hunt@intel.com>
|
Gah - this gets me every time! 😄 /retest |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Correct typos and resolve formatting issues including incorrect heading levels and missing TOC entries.
Fixes: #541.
Signed-off-by: James O. D. Hunt james.o.hunt@intel.com