Stable 1.1.1 candidate #104
Conversation
|
@jodh-intel @bergwolf @devimc PTAL and ACK |
Codecov Report
@@ Coverage Diff @@
## stable-1.1 #104 +/- ##
==============================================
+ Coverage 34.21% 36.79% +2.58%
==============================================
Files 2 2
Lines 228 250 +22
==============================================
+ Hits 78 92 +14
- Misses 139 150 +11
+ Partials 11 8 -3 |
|
Build failed (third-party-check pipeline) integration testing with
|
|
CPU tests are not happy, |
egernst
force-pushed
the
stable-1.1.1-candidate
branch
from
1fd3f59
to
d720dcf
Compare
|
@egernst - this branch has conflicts. |
Use the standard `logrus.WithError()` API to handle logging of all errors. Fixes #85. Signed-off-by: James O. D. Hunt <james.o.hunt@intel.com>
Rather than just returning (or continuing in some cases), always `exit(1)` on fatal error to indicate failure. Signed-off-by: James O. D. Hunt <james.o.hunt@intel.com>
The `setupLogger()` function used to ignore a failure to create a syslog hook. This is not what we want since without it, all output will go to `stderr`, which will be discarded. Signed-off-by: James O. D. Hunt <james.o.hunt@intel.com>
The version of bash provided by OSX under Travis is too old to support `typeset -A`, so install a newer version using homebrew. Signed-off-by: James O. D. Hunt <james.o.hunt@intel.com>
For parity with other system components, Change the initial log message to show the standard "announce" message tag along with fields for each of the command-line options. Signed-off-by: James O. D. Hunt <james.o.hunt@intel.com>
When cleaning up, we need to make sure the yamux session is closed as well. It does not close the session by just closing the listener. OTOH, it closes all streams if the session is closed. Fixes: #93 Signed-off-by: Peng Tao <bergwolf@gmail.com> Signed-off-by: Eric Ernst <eric.ernst@intel.com>
yamux stream closing is aync. Use a wait group to make sure when we quit the serve() goroutine, all the stream copy goroutines have quited as well. Signed-off-by: Peng Tao <bergwolf@gmail.com>
Capture yamux messages to the logger. Fixes #88. Signed-off-by: James O. D. Hunt <james.o.hunt@intel.com> Signed-off-by: Eric Ernst <eric.ernst@intel.com>
Correct an invalid use of the logger where an argument was passed to `Debug()` (should have been `Debugf()`) by using of `WithError()` instead. Fixes #98. Signed-off-by: James O. D. Hunt <james.o.hunt@intel.com>
Add DESTDIR variable, by default the path is `/` (root). Default variables: PREFIX := usr LIBEXECDIR := libexec PROJECT := kata-containers If someone does not want to use those varibles can use INSTALLDIR. If defined the kata-proxy will be intalled in the new destination defined there. Fixes: #101 Signed-off-by: Jose Carlos Venegas Munoz <jose.carlos.venegas.munoz@intel.com>
egernst
force-pushed
the
stable-1.1.1-candidate
branch
from
d720dcf
to
8fc1630
Compare
|
Build failed (third-party-check pipeline) integration testing with
|
|
CPU test still running (and failing) in initrd job should be skipped. |
|
travis job failing in |
|
centos job failing edit: |
|
Ouch! But great that the soak test caught this! Do you recall which commit might be problematic @grahamwhaley? |
|
We did a fix to locate the correct QEMU path - that could be it - a fix to the test that is. Let me go peek |
|
Could it be this: kata-containers/tests#611 |
|
ready to merge |
|
Giving the last Travis build one last opportunity to pass... ;) |
|
The Travis error is osx only (missing yq issue), so... lgtm |
|
lgtm |
analyzed each patch from HEAD (6f209b7) to 1.1.0.
Analysis:
1.1.1 | * 494d0d8 Makefile: Add DESTDIR variable support.
1.1.1 | * 7fd3734 logging: Fix incorrect logger usage
1.1.1 | * ec252d8 logging: Redirect yamux warnings/errors to logger
1.1.1 | * 1fbb8b3 proxy: wait copy goroutine to quit
1.1.1 | * 22c6f40 proxy: close yamux session properly
NO * c416c9f Merge pull request #91 from sboeuf/introduce_heartbeat_yamux
| * 063d58f proxy: Maintain communication state with a heartbeat
NO | * 1672418 logging: Add sandbox CLI option
1.1.1 | * 9b6bb05 logging: Display standard announce message
1.1.1 | * 246f707 CI: Update bash on Travis OSX for hashes
1.1.1 | * 73dbb10 logger: Die if unable to create syslog hook
1.1.1 | * 0cfa402 main: Exit on fatal error
1.1.1 | * 7681a94 logging: Use WithError() for all errors