Skip to content
This repository has been archived by the owner on May 12, 2021. It is now read-only.

Get rid of nested vendor directories #1909

Closed
amshinde opened this issue Jul 24, 2019 · 1 comment · Fixed by #1910
Closed

Get rid of nested vendor directories #1909

amshinde opened this issue Jul 24, 2019 · 1 comment · Fixed by #1910
Labels
bug Incorrect behaviour needs-review Needs to be assessed by the team.

Comments

@amshinde
Copy link
Member

dep's recommended approach is not to have nested vendor directories:
golang/dep#985
@amshinde amshinde added bug Incorrect behaviour needs-review Needs to be assessed by the team. labels Jul 24, 2019
@amshinde
Copy link
Member Author

cc @ganeshmaharaj @jodh-intel
Would be good to fix this before the move t o modules.

amshinde added a commit to amshinde/kata-runtime that referenced this issue Jul 24, 2019
@amshinde
dep: Remove nested vendor directories
95e8a7a 
It is not really recommended to have nested vendor directories.
dep does not work well with nested directories:
golang/dep#985
Recommendation is to use flatten the vendor directories.

Hence remove any nested vendor directories.

Fixes kata-containers#1909

Signed-off-by: Archana Shinde <archana.m.shinde@intel.com>
@amshinde amshinde mentioned this issue Jul 24, 2019
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug Incorrect behaviour needs-review Needs to be assessed by the team.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove nested vendor dir amshinde/kata-runtime
1 participant
@amshinde