Skip to content
This repository has been archived by the owner on May 12, 2021. It is now read-only.

Type of Statfs_t struct on s390x is uint32 not int64 #908

Closed
alicefr opened this issue Nov 15, 2018 · 0 comments
Closed

Type of Statfs_t struct on s390x is uint32 not int64 #908

alicefr opened this issue Nov 15, 2018 · 0 comments

Comments

@alicefr
Copy link
Member

alicefr commented Nov 15, 2018 •
edited
Loading

In go Type of the struct Statfs_t is int64 for amd64, arm and ppc64le. However, on s390 the Type is uint32. In oci/cli.go, you convert directly the cgroupFsType to int64. For this reason, on s390 the build fails:

$ make 
# github.com/kata-containers/runtime/cli
./oci.go:251:17: invalid operation: statFs.Type != int64(cgroupFsType) (mismatched types uint32 and int64)
Makefile:328: recipe for target '/root/go/src/github.com/kata-containers/runtime/kata-runtime' failed
make: *** [/root/go/src/github.com/kata-containers/runtime/kata-runtime] Error 2
@alicefr alicefr mentioned this issue Nov 15, 2018
Closed
50 tasks
alicefr pushed a commit to alicefr/runtime that referenced this issue Nov 15, 2018
build: introduction of archConvertStatFs function
9d59c48 
Fixes: kata-containers#908

Type of StatFs is not always declared as int64 for all the architecture(e.g s390x).
The function archConvertStatFs could be reimplemented for other architecture
to correctly convert the StatFs.Type.

Signed-off-by: Alice Frosi <afrosi@de.ibm.com>
@alicefr alicefr mentioned this issue Nov 15, 2018
Merged
alicefr pushed a commit to alicefr/runtime that referenced this issue Nov 15, 2018
build: introduction of archConvertStatFs function
4594c85 
Fixes: kata-containers#908

Not all the architectures convert the StatFs to int64 (e.g s390x). The
function archConvertStatFs could be reimplemented for other architecture
to correctly convert the StatFs.Type.

Signed-off-by: Alice Frosi <afrosi@de.ibm.com>
alicefr pushed a commit to alicefr/runtime that referenced this issue Nov 15, 2018
build: introduction of archConvertStatFs function
2c50c93 
Fixes: kata-containers#908

Type of StatFs is not always declared as int64 for all the architecture(e.g s390x).
The function archConvertStatFs could be reimplemented for other architecture
to correctly convert the StatFs.Type.

Signed-off-by: Alice Frosi <afrosi@de.ibm.com>
alicefr pushed a commit to alicefr/runtime that referenced this issue Nov 15, 2018
build: introduction of archConvertStatFs function
b185f31 
Type of StatFs is not always declared as int64 for all the architecture(e.g s390x).
The function archConvertStatFs could be reimplemented for other architecture
to correctly convert the StatFs.Type.

Fixes: kata-containers#908

Signed-off-by: Alice Frosi <afrosi@de.ibm.com>
zklei pushed a commit to zklei/runtime that referenced this issue Nov 22, 2018
@zklei
build: introduction of archConvertStatFs function
4a18b57 
Type of StatFs is not always declared as int64 for all the architecture(e.g s390x).
The function archConvertStatFs could be reimplemented for other architecture
to correctly convert the StatFs.Type.

Fixes: kata-containers#908

Signed-off-by: Alice Frosi <afrosi@de.ibm.com>
zklei pushed a commit to zklei/runtime that referenced this issue Nov 22, 2018
@zklei
build: introduction of archConvertStatFs function
3353b54 
Type of StatFs is not always declared as int64 for all the architecture(e.g s390x).
The function archConvertStatFs could be reimplemented for other architecture
to correctly convert the StatFs.Type.

Fixes: kata-containers#908

Signed-off-by: Alice Frosi <afrosi@de.ibm.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@alicefr