Skip to content
This repository has been archived by the owner on May 12, 2021. It is now read-only.

make: add ability to skip go version check #916

Closed
marcov opened this issue Nov 16, 2018 · 1 comment
Closed

make: add ability to skip go version check #916

marcov opened this issue Nov 16, 2018 · 1 comment

Comments

@marcov
Copy link
Contributor

marcov commented Nov 16, 2018

It should be possible to skip checking the go version, when for example the runtime is built for being packaged (i.e., by OBS).

That's because:

  • checking the go version requires yq, and that may not be available as a package. Downloading it from the internet is also not an option, OBS cannot access the network.
  • when packaging, the package maintainer is supposed to specify the correct go version needed to build the runtime.
marcov added a commit to marcov/kata-runtime that referenced this issue Nov 16, 2018
Add the ability to skip checking the go version, by passing to make the
variable SKIP_GO_VERSION_CHECK=1

Fixes: kata-containers#916

Signed-off-by: Marco Vedovati <mvedovati@suse.com>
@jodh-intel
Copy link
Contributor

Agreed!

zklei pushed a commit to zklei/runtime that referenced this issue Nov 22, 2018
Add the ability to skip checking the go version, by passing to make the
variable SKIP_GO_VERSION_CHECK=1

Fixes: kata-containers#916

Signed-off-by: Marco Vedovati <mvedovati@suse.com>
zklei pushed a commit to zklei/runtime that referenced this issue Nov 22, 2018
Add the ability to skip checking the go version, by passing to make the
variable SKIP_GO_VERSION_CHECK=1

Fixes: kata-containers#916

Signed-off-by: Marco Vedovati <mvedovati@suse.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants