This repository has been archived by the owner on May 12, 2021. It is now read-only.
qemu: pass rootfs image in readonly mode #2477
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
bergwolf
commented
Feb 19, 2020
•
bergwolf
commented
- update govmm vendor
- fix up vhost user device after govmm vendor update
- pass guest rootfs image in readonly mode
bergwolf
added
backport
wip
amshinde
approved these changes
Feb 19, 2020
bergwolf
changed the title
bergwolf
removed
the
wip
|
/test |
Codecov Report
@@ Coverage Diff @@
## master #2477 +/- ##
=========================================
Coverage ? 50.74%
=========================================
Files ? 116
Lines ? 16538
Branches ? 0
=========================================
Hits ? 8392
Misses ? 7120
Partials ? 1026 |
To include block readonly capability. Included commits: 3700c55 qemu: add block device readonly support 88a25a2 Refactor code to support multiple virtio transports at runtime 2ee53b0 qemu: Don't set ".cache-size=" when CacheSize is 0 Signed-off-by: Peng Tao <bergwolf@hyper.sh>
So that we fobid guest from making changes to it. Fixes: kata-containers#2476 Signed-off-by: Peng Tao <bergwolf@hyper.sh>
bergwolf
force-pushed
the
ro
branch
2 times, most recently
from
63ea8b2
to
7104fe2
Compare
For one thing, we should not make kata's internal device type exactly as govmm string by string. For another thing, latest govmm changes the device driver strings and it breaks kata in such a way but the fault is on kata side IMHO. Signed-off-by: Peng Tao <bergwolf@hyper.sh>
|
/test |
|
|
lifupan
approved these changes
Feb 26, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.