This repository has been archived by the owner on May 12, 2021. It is now read-only.
virtcontainers: fix the issue of cleanup the vm's path #544
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To use the filepath.Join() instead of the simple string append method to form the file path, otherwise it will lose the "/" between the two parts. Fixes kata-containers#543. Signed-off-by: Fupan Li <lifupan@gmail.com>
|
Nice! lgtm |
|
PSS Measurement: Memory inside container: |
grahamwhaley
approved these changes
Aug 2, 2018
|
I've kicked centos-7.4 CI to rebuild, as it looked like a network error. |
|
Build failed (third-party-check pipeline) integration testing with
|
Codecov Report
@@ Coverage Diff @@
## master #544 +/- ##
=======================================
Coverage 66.54% 66.54%
=======================================
Files 94 94
Lines 9678 9678
=======================================
Hits 6440 6440
Misses 2546 2546
Partials 692 692 |
|
LGTM Good catch~ |
|
Ignoring openstack CI fail. All else is green, so merging... |
Merged
zklei
pushed a commit
to zklei/runtime
that referenced
this pull request
Jun 13, 2019
For now, update interface in agent will fail when hot-add nic to a running containers on arm64 as rescan pci bus will occur between uf and bf of shpc hotplug interrupt handling. Another problem is that the rootBusPath will be "/devices/platform/4010000000.pcie/pci0000:00" on arm64. To enable hot-add nic on arm64, rootBusPath should be changed here and shpc hotplug should be disabled in guest kernel. This patch just change rootBusPath. Fixes: kata-containers#544 Signed-off-by: Jianyong Wu <jianyong.wu@arm.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To use the filepath.Join() instead of the simple
string append method to form the file path, otherwise
it will lose the "/" between the two parts.
Fixes #543.
Signed-off-by: Fupan Li lifupan@gmail.com