This repository has been archived by the owner on May 12, 2021. It is now read-only.
virtcontainers: share the agent's client between factory's VM and san… #996
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/test |
bergwolf
reviewed
Dec 10, 2018
virtcontainers/agent.go
Outdated
| getClient() interface{} | ||
|
|
||
| // set to use an existing agent's client | ||
| setClient(client interface{}) error |
There was a problem hiding this comment.
What about reuseAgent(a agent) error API and internally assert agent is of the right type and reuse agent.client internally. Then we don't expose interface{} and agent's internal knowledge around.
There was a problem hiding this comment.
Yeah, it's a good idea, I'll update it.
…dbox When agent is configured as longLive, the VM's agent created by factory will not close it's client once it connected, thus the sandbox's agent cannot re-connect successfully. Sharing the agent's client between VM's agent and sandbox can fix this issue. Fixes: kata-containers#995 Signed-off-by: fupan <lifupan@gmail.com>
|
/test |
|
LGTM, thanks! |
|
lgtm |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…dbox
When agent is configured as longLive, the VM's agent created
by factory will not close it's client once it connected, thus
the sandbox's agent cannot re-connect successfully.
Sharing the agent's client between VM's agent and sandbox
can fix this issue.
Fixes: #995
Signed-off-by: Fupan Li lifupan@gmail.com