Skip to content
This repository has been archived by the owner on Jun 28, 2024. It is now read-only.

ci: static-checks: checking vendored files seems to be broken #1733

Closed
chavafg opened this issue Jun 18, 2019 · 0 comments
Closed

ci: static-checks: checking vendored files seems to be broken #1733

chavafg opened this issue Jun 18, 2019 · 0 comments
Labels
bug Incorrect behaviour needs-review Needs to be assessed by the team.

Comments

@chavafg
Copy link
Contributor

chavafg commented Jun 18, 2019

Investigating with @ganeshmaharaj, seems that our check for vendored files is not working correctly as dep ensure --dry-run seems to return zero even when changes are needed.
E.g.

$ ~/go/bin/dep ensure --dry-run
Would have written Gopkg.lock.
Would have updated the following projects in the vendor directory:

(0/3) Would have written github.com/blang/semver@v3.6.1: new project
(0/3) Would have written github.com/hashicorp/go-multierror@v1.0.0: prune options changed ( -> NUT)
(0/3) Would have written github.com/hashicorp/errwrap@v1.0.0: prune options changed ( -> NUT)
$ echo $?
0
@chavafg chavafg added bug Incorrect behaviour needs-review Needs to be assessed by the team. labels Jun 18, 2019
@jodh-intel jodh-intel mentioned this issue Jul 10, 2019
Merged
ganeshmaharaj pushed a commit to ganeshmaharaj/kata-tests that referenced this issue Jul 10, 2019
ci: Check vendor sync
a6bb1ab 
dep ensure -dry-run -no-vendor will check and show if vendor code is out
of sync with GOpkg files but always has a return code of 0. Switching it
to dep check will fail if Gopkg is not in sync with vendor.

Fixes: kata-containers#1794
Fixes: kata-containers#1733
Signed-off-by: Ganesh Maharaj Mahalingam <ganesh.mahalingam@intel.com>
ganeshmaharaj pushed a commit to ganeshmaharaj/kata-tests that referenced this issue Jul 25, 2019
vendor: Unify Gopkg files and vendor folder within the repository
3bcdea1 
This repository contains multiple Gopkg.* files which defines
dependencies for each stand-alone application within this repository.
This was posing an issue where there was no predictable way of
confirming that vendor folder is in sync with the versions defined in
Gopkg files. dep tool does not handle multiple sub folder definitions
and is not a feature that is in their pipeline. This effort is to unify
all the dependencies to allow `dep check` on the repository. Check
golang/dep#985 for dep issues with nesting.

Fixes: kata-containers#1794
Fixes: kata-containers#1733
Signed-off-by: Ganesh Maharaj Mahalingam <ganesh.mahalingam@intel.com>
ganeshmaharaj pushed a commit to ganeshmaharaj/kata-tests that referenced this issue Jul 25, 2019
ci: Check vendor folder sync
adfaab9 
dep ensure -dry-run -no-vendor will check and show if vendor code is out
of sync with GOpkg files but always has a return code of 0. Switching it
to dep check will fail if Gopkg is not in sync with vendor.

Fixes: kata-containers#1794
Fixes: kata-containers#1733
Signed-off-by: Ganesh Maharaj Mahalingam <ganesh.mahalingam@intel.com>
ganeshmaharaj pushed a commit to ganeshmaharaj/kata-tests that referenced this issue Jul 26, 2019
vendor: Unify Gopkg files and vendor folder within the repository
9a175b9 
This repository contains multiple Gopkg.* files which defines
dependencies for each stand-alone application within this repository.
This was posing an issue where there was no predictable way of
confirming that vendor folder is in sync with the versions defined in
Gopkg files. dep tool does not handle multiple sub folder definitions
and is not a feature that is in their pipeline. This effort is to unify
all the dependencies to allow `dep check` on the repository. Check
golang/dep#985 for dep issues with nesting.

Fixes: kata-containers#1794
Fixes: kata-containers#1733
Signed-off-by: Ganesh Maharaj Mahalingam <ganesh.mahalingam@intel.com>
ganeshmaharaj pushed a commit to ganeshmaharaj/kata-tests that referenced this issue Jul 26, 2019
ci: Check vendor folder sync
bc6202f 
dep ensure -dry-run -no-vendor will check and show if vendor code is out
of sync with GOpkg files but always has a return code of 0. Switching it
to dep check will fail if Gopkg is not in sync with vendor.

Fixes: kata-containers#1794
Fixes: kata-containers#1733
Signed-off-by: Ganesh Maharaj Mahalingam <ganesh.mahalingam@intel.com>
ganeshmaharaj pushed a commit to ganeshmaharaj/kata-tests that referenced this issue Jul 26, 2019
vendor: Unify Gopkg files and vendor folder within the repository
1c7ef35 
This repository contains multiple Gopkg.* files which defines
dependencies for each stand-alone application within this repository.
This was posing an issue where there was no predictable way of
confirming that vendor folder is in sync with the versions defined in
Gopkg files. dep tool does not handle multiple sub folder definitions
and is not a feature that is in their pipeline. This effort is to unify
all the dependencies to allow `dep check` on the repository. Check
golang/dep#985 for dep issues with nesting.

Fixes: kata-containers#1794
Fixes: kata-containers#1733
Signed-off-by: Ganesh Maharaj Mahalingam <ganesh.mahalingam@intel.com>
ganeshmaharaj pushed a commit to ganeshmaharaj/kata-tests that referenced this issue Jul 26, 2019
ci: Check vendor folder sync
f5f84d8 
dep ensure -dry-run -no-vendor will check and show if vendor code is out
of sync with GOpkg files but always has a return code of 0. Switching it
to dep check will fail if Gopkg is not in sync with vendor.

Fixes: kata-containers#1794
Fixes: kata-containers#1733
Signed-off-by: Ganesh Maharaj Mahalingam <ganesh.mahalingam@intel.com>
ganeshmaharaj pushed a commit to ganeshmaharaj/kata-tests that referenced this issue Jul 26, 2019
vendor: Unify Gopkg files and vendor folder within the repository
16cc8ab 
This repository contains multiple Gopkg.* files which defines
dependencies for each stand-alone application within this repository.
This was posing an issue where there was no predictable way of
confirming that vendor folder is in sync with the versions defined in
Gopkg files. dep tool does not handle multiple sub folder definitions
and is not a feature that is in their pipeline. This effort is to unify
all the dependencies to allow `dep check` on the repository. Check
golang/dep#985 for dep issues with nesting.

Fixes: kata-containers#1794
Fixes: kata-containers#1733
Signed-off-by: Ganesh Maharaj Mahalingam <ganesh.mahalingam@intel.com>
ganeshmaharaj pushed a commit to ganeshmaharaj/kata-tests that referenced this issue Jul 26, 2019
ci: Check vendor folder sync
ba270c9 
dep ensure -dry-run -no-vendor will check and show if vendor code is out
of sync with GOpkg files but always has a return code of 0. Switching it
to dep check will fail if Gopkg is not in sync with vendor.

Fixes: kata-containers#1794
Fixes: kata-containers#1733
Signed-off-by: Ganesh Maharaj Mahalingam <ganesh.mahalingam@intel.com>
ganeshmaharaj pushed a commit to ganeshmaharaj/kata-tests that referenced this issue Jul 26, 2019
ci: Check vendor folder sync
f569f35 
dep ensure -dry-run -no-vendor will check and show if vendor code is out
of sync with GOpkg files but always has a return code of 0. Switching it
to dep check will fail if Gopkg is not in sync with vendor.

Fixes: kata-containers#1794
Fixes: kata-containers#1733
Signed-off-by: Ganesh Maharaj Mahalingam <ganesh.mahalingam@intel.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug Incorrect behaviour needs-review Needs to be assessed by the team.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@chavafg