Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: use virtio-blk device driver #110

Merged
merged 1 commit into from
Mar 9, 2018

Conversation

chavafg
Copy link
Contributor

@chavafg chavafg commented Mar 2, 2018

Modify kata-runtime configuration to set:
block_device_driver = "virtio-blk"

Fixes: #107

Signed-off-by: Salvador Fuentes salvador.fuentes@intel.com

@chavafg chavafg added the review label Mar 2, 2018
@chavafg
Copy link
Contributor Author

chavafg commented Mar 2, 2018

Adding do-not-merge label as clearcontainers/runtime#1044 needs to be merged and then we need to update the runtime version

@sboeuf
Copy link

sboeuf commented Mar 2, 2018

This is temporary since we'll need scsi for reliable testing when we'll have moved to Qemu >= 2.9, but for now:
LGTM

Copy link
Member

@amshinde amshinde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jodh-intel
Copy link
Contributor

jodh-intel commented Mar 5, 2018

lgtm

Approved with PullApprove

Modify kata-runtime configuration to set:
block_device_driver = "virtio-blk"

Fixes: kata-containers#107

Signed-off-by: Salvador Fuentes <salvador.fuentes@intel.com>
@chavafg
Copy link
Contributor Author

chavafg commented Mar 9, 2018

This can be merged now, but I see that using virtio-scsi is also working correctly.
@sboeuf do you think we need this change?

@chavafg
Copy link
Contributor Author

chavafg commented Mar 9, 2018

Talking with @sboeuf we need this change to test device passthrough

@GabyCT
Copy link
Contributor

GabyCT commented Mar 9, 2018

lgtm

Approved with PullApprove

@GabyCT GabyCT merged commit f8a4284 into kata-containers:master Mar 9, 2018
@amshinde amshinde removed the review label Mar 9, 2018
@chavafg chavafg deleted the topic/virtio branch May 31, 2018 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants