log-parser: Support reading from stdin #112
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Blocked on clearcontainers/runtime#1044. |
jodh-intel
force-pushed
the
log-parser-allow-stdin-read
branch
from
43d2bd6
to
d4dcb83
Compare
|
ping @kata-containers/tests. |
|
lgtm |
|
@jodh-intel can you please rebase to let the CI pass? |
|
lgtm |
Document `HexByteReader.Read()` more clearly. Signed-off-by: James O. D. Hunt <james.o.hunt@intel.com>
Allow the `file` argument to be specified as "`-`" meaning "read from standard input". Fixes kata-containers#111. Signed-off-by: James O. D. Hunt <james.o.hunt@intel.com>
jodh-intel
force-pushed
the
log-parser-allow-stdin-read
branch
from
d4dcb83
to
8b61758
Compare
|
All done. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow the
fileargument to be specified as "-" meaning"read from standard input".
Fixes #111.
Signed-off-by: James O. D. Hunt james.o.hunt@intel.com