GitHub label changes #1653
GitHub label changes #1653
Conversation
The `bug` label really should stand out a bit so make it explicitly red (which is the default for GitHub). Signed-off-by: James O. D. Hunt <james.o.hunt@intel.com>
|
Anyone up for a spot of bikeshedding? Should the new label be called
Related: kata-containers/kata-containers#39. |
|
@egernst - also, I'm in two minds about adding an "Ask a question" type of issue. Maybe we can live with bug, feature and enhancement for now? https://github.com/kata-containers/.github/issues/new/choose |
cmd/github-labels/labels.yaml.in
Outdated
| @@ -361,6 +361,11 @@ labels: | |||
| category: vendor | |||
| color: DEFAULT_COLOUR | |||
|
|
|||
| - name: needs-triage | |||
There was a problem hiding this comment.
Personally, I prefer needs-review. Ack that 'triage' is maybe less obvious
There was a problem hiding this comment.
Yeah - I was hoping someone would agree 😄. Branch updated (with a Fixes too! :)
There was a problem hiding this comment.
review sounds more like a PR item, not an issue to me. I prefer triage, but don't care that much :)
There was a problem hiding this comment.
Thanks @egernst. One vote for and one against so do we need a tie-breaker?
| Label name | Pros | Cons | Applies to issues | Applies to PRs |
|---|---|---|---|---|
triage |
Implies "initial" [1]. Well understood for native English speakers. | Could be confusing if non-native English speaker. | Yes | "yes", but would sound "wrong" |
review |
More easily understood by all | ? | yes | yes |
assessment |
Implies "initial" [1] | ? | yes | yes |
Note: If we really want triage, we might be able to discount the non-native English speaker argument given that all the labels are documented?
Any thoughts @kata-containers/architecture-committee?
[1] - Which works well for issues.
There was a problem hiding this comment.
Can you attach emojis to labels? 🚑 :-)
I'm fine with triage if we don't get a deciding vote.
There was a problem hiding this comment.
Better than that - you can use emoji's as labels! 😄
There was a problem hiding this comment.
But that could get confusing what with the similarity of things like 🌰 with "other things" 😁
There was a problem hiding this comment.
@egernst - soz - this got merged before we really finished the chat. I've applied needs-review to all the repos but can change to needs-triage if you want (along with a new PR to update the master YAML this PR changed)?
|
Heh, no |
Added a new `needs-review` label. The idea is that the new GitHub issue templates can all add this label when issues are created. The Triage Team will then review the new issues, add any missing labels and *remove* the `needs-review` label. The `needs-review` label thus provides a simple way to identify issues that have not been looked at yet. The label could also be applied to PRs in some circumstances. Note that the original name of a `needs-triage` label was rejected since: - Triage is an unusual word which may be confusing to users. - Triage implies "initial" so would only really make sense for issues. Fixes: kata-containers#1658. Signed-off-by: James O. D. Hunt <james.o.hunt@intel.com>
jodh-intel
force-pushed
the
github-label-changes
branch
from
f6fb1d2
to
4d2181b
Compare
|
One more ack needed over here. Whilst we wait... /test |
Added a new
needs-triagelabel. The idea is that the new GitHub issue templates can all add this label when issues are created. The Triage Team will then review the new issues, add any missing labels andremove the
needs-triagelabel. Theneeds-triagelabel thus provides a simple way to identify issuesthat have not been looked at yet.
Also changed the
buglabel to red.Signed-off-by: James O. D. Hunt james.o.hunt@intel.com