Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

k8s: e2e: Enable podOverhead feature and modify skipped tests #2243

Merged
merged 3 commits into from Jan 24, 2020

Conversation

chavafg
Copy link
Contributor

@chavafg chavafg commented Jan 20, 2020

We are using k8s 1.16, so we can enable PodOverhead alpha
feature for our testing.

In addition, modify skipped tests:

  • Remove Downward API tests from the list of skipped tests.
    These tests pass when enabling the PodOverhead feature on
    kubernetes.
  • Add a Daemon set test which requires to have a cluster
    with at least two nodes.

Fixes: #2242.

@devimc
Copy link

devimc commented Jan 20, 2020

/test

Copy link
Contributor

@grahamwhaley grahamwhaley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@chavafg chavafg added the do-not-merge PR has problems or depends on another label Jan 21, 2020
@chavafg
Copy link
Contributor Author

chavafg commented Jan 21, 2020

adding DNM as I am still testing the e2e suite with these changes.

We are using k8s 1.16, so we can enable PodOverhead alpha
feature for our testing.

Signed-off-by: Salvador Fuentes <salvador.fuentes@intel.com>
- Remove `Downward API` tests from the list of skipped tests.
  These tests pass when enabling the `PodOverhead` feature on
  kubernetes.
- Add a `Daemon set` test which requires to have a cluster
  with at least two nodes.

Fixes: kata-containers#2242.

Signed-off-by: Salvador Fuentes <salvador.fuentes@intel.com>
@chavafg chavafg removed the do-not-merge PR has problems or depends on another label Jan 23, 2020
@chavafg
Copy link
Contributor Author

chavafg commented Jan 23, 2020

/test-ubuntu

We need to lower the request of CPUs on the pod-number-cpu.yaml
which is used to run our CPU test. This is required as we now
have enabled PodOverhead and our CI VMs are small.

In addition, increase the sleep time that is run inside one of the
containers, so that we are sure that we can measure the number
of CPUs that it is using.

Signed-off-by: Salvador Fuentes <salvador.fuentes@intel.com>
@chavafg
Copy link
Contributor Author

chavafg commented Jan 23, 2020

/test-ubuntu

@chavafg
Copy link
Contributor Author

chavafg commented Jan 23, 2020

/test

@GabyCT GabyCT merged commit 9781d08 into kata-containers:master Jan 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

k8s: e2e: Add podOverhead feature and modify skipped tests
6 participants