New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
k8s: e2e: Enable podOverhead feature and modify skipped tests #2243
Merged
GabyCT
merged 3 commits into
kata-containers:master
from
chavafg:topic/k8s-pod-overhead
Jan 24, 2020
Merged
k8s: e2e: Enable podOverhead feature and modify skipped tests #2243
GabyCT
merged 3 commits into
kata-containers:master
from
chavafg:topic/k8s-pod-overhead
Jan 24, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
/test |
jodh-intel
approved these changes
Jan 21, 2020
grahamwhaley
approved these changes
Jan 21, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
adding DNM as I am still testing the e2e suite with these changes. |
chavafg
force-pushed
the
topic/k8s-pod-overhead
branch
from
January 21, 2020 20:25
1fbf8f6
to
6b937e8
Compare
amshinde
approved these changes
Jan 22, 2020
We are using k8s 1.16, so we can enable PodOverhead alpha feature for our testing. Signed-off-by: Salvador Fuentes <salvador.fuentes@intel.com>
chavafg
force-pushed
the
topic/k8s-pod-overhead
branch
from
January 22, 2020 21:12
6b937e8
to
4b7721f
Compare
- Remove `Downward API` tests from the list of skipped tests. These tests pass when enabling the `PodOverhead` feature on kubernetes. - Add a `Daemon set` test which requires to have a cluster with at least two nodes. Fixes: kata-containers#2242. Signed-off-by: Salvador Fuentes <salvador.fuentes@intel.com>
chavafg
force-pushed
the
topic/k8s-pod-overhead
branch
from
January 23, 2020 17:50
4b7721f
to
f248769
Compare
/test-ubuntu |
We need to lower the request of CPUs on the pod-number-cpu.yaml which is used to run our CPU test. This is required as we now have enabled PodOverhead and our CI VMs are small. In addition, increase the sleep time that is run inside one of the containers, so that we are sure that we can measure the number of CPUs that it is using. Signed-off-by: Salvador Fuentes <salvador.fuentes@intel.com>
/test-ubuntu |
/test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are using k8s 1.16, so we can enable PodOverhead alpha
feature for our testing.
In addition, modify skipped tests:
Downward API
tests from the list of skipped tests.These tests pass when enabling the
PodOverhead
feature onkubernetes.
Daemon set
test which requires to have a clusterwith at least two nodes.
Fixes: #2242.