containerd: fix the issue of getting cri version #3629
Conversation
|
/test |
|
/test |
|
/retest |
.ci/install_cri_containerd.sh
Outdated
| echo "Get cri_containerd version" | ||
| cri_containerd_version_url="https://raw.githubusercontent.com/containerd/containerd/${cri_containerd_tarball_version}/vendor.conf" | ||
| cri_containerd_version=$(curl -sL $cri_containerd_version_url | grep "github.com/containerd/cri" | awk '{print $2}') | ||
| cri_containerd_version=$(cri_containerd_tarball_version) |
There was a problem hiding this comment.
Should this be cri_containerd_version="$cri_containerd_tarball_version"
The CI run into this error:
03:19:00 .ci/install_cri_containerd.sh: line 32: cri_containerd_tarball_version: command not found
03:19:01 Failed at 32: cri_containerd_version=$(cri_containerd_tarball_version)
lifupan
force-pushed
the
main
branch
5 times, most recently
from
ab6846e
to
6ea8679
Compare
|
/test |
lifupan
force-pushed
the
main
branch
11 times, most recently
from
1dddb52
to
8d4382a
Compare
|
/test-ubuntu |
|
/test |
|
Hi， @fidencio |
|
@lifupan, sure, let me dig into this. |
|
/test |
|
The error we're getting is interesting, at least: And this is coming from the agent. |
Oh, I got it. Since the upgrading containerd vendor bring the oci runtime spec's upgrading, and the latest oci spec redefined some fields. |
Did you? I'm still confused, to be honest, and would appreciate some light to the issue. |
Since 1.5.0, containerd had embedded cri and there's no need to get the cri version. Depends-on: github.com/kata-containers/kata-containers#2040 Fixes:kata-containers#3630 Signed-off-by: fupan.lfp <fupan.lfp@antgroup.com>
|
/retest |
|
Hi @fidencio The CI worked, and it's ready for your review. |
Since the rpc spec used an interface to represen the ErrnoRet, thus the transform function of OCItoGRPC should take care of this case. Depends-on: github.com/kata-containers/tests#3629 Fixes: kata-containers#1441 Signed-off-by: fupan.lfp <fupan.lfp@antgroup.com>
Since the rpc spec used an interface to represen the ErrnoRet, thus the transform function of OCItoGRPC should take care of this case. Depends-on: github.com/kata-containers/tests#3629 Fixes: kata-containers#1441 Signed-off-by: fupan.lfp <fupan.lfp@antgroup.com>
Since latest versions, containerd had embedded cri and there's no need to get the cri version. Depends-on: github.com/kata-containers/kata-containers#2222 Fixes:kata-containers#3630 Backports: kata-containers#3629 Signed-off-by: fupan.lfp <fupan.lfp@antgroup.com> Signed-off-by: Fabiano Fidêncio <fidencio@redhat.com>
Since 1.5.0, containerd had embedded cri and there's no
need to get the cri version.
Depends-on: github.com/kata-containers/kata-containers#2040
Fixes:#3630
Signed-off-by: fupan.lfp fupan.lfp@antgroup.com