This repository has been archived by the owner on Jun 28, 2024. It is now read-only.
Checkcommits ignore release prs #37
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/cc @jcvenegas. |
jodh-intel
force-pushed
the
checkcommits-ignore-release-prs
branch
from
533f308
to
181f48f
Compare
|
Well, that's good - Travis is failing due to one of the static tests Blocked on clearcontainers/tests#869. |
|
clearcontainers/tests#869 now merged ;) |
Update the version of `checkcommits` to match the copy in https://github.com/clearcontainers/tests/tree/master/cmd/checkcommits. Signed-off-by: James O. D. Hunt <james.o.hunt@intel.com>
Change the `checkcommits` config to not require an issue for release PRs. Fixes kata-containers#28. Signed-off-by: James O. D. Hunt <james.o.hunt@intel.com>
jodh-intel
force-pushed
the
checkcommits-ignore-release-prs
branch
from
181f48f
to
9f38936
Compare
|
Thanks @chavafg - branch updated, so this should now pass under Travis... |
|
Travis is happy. Just need 2 acks from @kata-containers/tests now ;) |
grahamwhaley
approved these changes
Jan 23, 2018
|
lgtm |
jodh-intel
added a commit
to jodh-intel/tests-1
that referenced
this pull request
Jan 29, 2018
When PR kata-containers#37 landed, `checkcommits` started to log the internal commit object at the start of an error. This is incorrect as it should just log the commit hash. Fixes kata-containers#51. Signed-off-by: James O. D. Hunt <james.o.hunt@intel.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change the
checkcommitsconfig to not require an issue for releasePRs.
Fixes #28.