-
Notifications
You must be signed in to change notification settings - Fork 194
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: Don't look for the C version of virtiofsd (x86_64) #4792
Merged
fidencio
merged 1 commit into
kata-containers:main
from
fidencio:wip/fix-breakage-after-virtiofsd-switch
May 17, 2022
Merged
ci: Don't look for the C version of virtiofsd (x86_64) #4792
fidencio
merged 1 commit into
kata-containers:main
from
fidencio:wip/fix-breakage-after-virtiofsd-switch
May 17, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
/test |
fidencio
added
the
no-backport-needed
Changed do not need to be applied to an older branch / repository
label
May 16, 2022
For some reason it was not caught by the CI before, but the install_qemu script looks for the virtiofsd in the location where it should be if built and installed via QEMU. This is not needed anymore, at least for x86_64, as we're using the rust version of virtiofsd. Fixes: kata-containers#4791 Signed-off-by: Fabiano Fidêncio <fabiano.fidencio@intel.com>
fidencio
force-pushed
the
wip/fix-breakage-after-virtiofsd-switch
branch
from
May 16, 2022 19:24
0a9a36e
to
44bb10c
Compare
/test |
fengwang666
approved these changes
May 16, 2022
wainersm
approved these changes
May 16, 2022
cmaf
approved these changes
May 16, 2022
/retest-arm |
1 similar comment
/retest-arm |
ARM CI failure, unrelated to this PR.
/retest-arm |
/retest-arm |
bergwolf
approved these changes
May 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
no-backport-needed
Changed do not need to be applied to an older branch / repository
size/small
Small and simple task
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For some reason it was not caught by the CI before, but the install_qemu
script looks for the virtiofsd in the location where it should be if
built and installed via QEMU.
This is not needed anymore, at least for x86_64, as we're using the rust
version of virtiofsd.
Fixes: #4791
Signed-off-by: Fabiano Fidêncio fabiano.fidencio@intel.com