-
-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
File based session storage #702
Comments
Hello @krokite. It's a good idea. |
@krokite Thanks, actually it's very easy to make a session database for our session manager. We already had an implementation of this at kataras/go-sessions, I pushed it here with some minor fixes but I didn't test it on different operating systems, I let this to you, upgrade with @corebreaker and @hiveminded Please test this and push any improvements if necessary. |
Tested on Windows and worked, waiting for more testers.
Example: https://github.com/kataras/iris/blob/master/_examples/sessions/database/file/main.go (upgrade your local iris again, it should work now, please test it) |
I tested with the example:
|
Someone could confirm the result of my tests ? |
Hello @corebreaker , on Destroy it shouldn't send a new session id to the browser, is this an expected behavior? About the destroy, it doesn't work on any database because it doesn't update the database if len(store) == 0, I'll update the code and change the database interface a little, I will try to improve your last changes if that's ok with you. |
Hello @kataras, it's ok for me. Concerning the session ID, you are right the destroy doesn't send a new session ID, but i meant, in my test, after i done the destroy, then i refreshed the browser, a new session id wasn't sent. Maybe it's due to the file isn't removed after a destroy. I think your changes will make that the session will be invalidated by a destroy and so the browser refresh will order a new session ID. |
Former-commit-id: 7ca4183ee0602936d8270d6e7dac6bec3d3fa2b5
…ot tested on every OS, yet) Former-commit-id: fb98f86f2a602d543ca1abb5281a30af96462c11
Tested on Windows and worked, waiting for more testers. Former-commit-id: 2b5be0202c1124f424d2276948c3203677f26a56
Hi, I see "iris" is back up with v8.x . Congratulation to team and @hiveminded
Does Iris / get-ion supports file based session ? Memory based session and database sessions are not optimal requirement for scaling up.
If it's not already there, is it hard to implement them ? Please share some light so that , i can try implementing them.
Thanks
Reference: get-ion/issues-v1#8
The text was updated successfully, but these errors were encountered: