redis-database session bug

[sy264115809]

Hi @kataras , i found that there is another bug in this line:

// ...
storeMaybe, err := db.redis.Get(sid)
if err != nil {
	golog.Errorf("error while trying to load session values(%s) from redis: %v", sid, err)
	return
}

storeDB, ok := storeMaybe.(sessions.RemoteStore) // <- here
if !ok {
	golog.Errorf(`error while trying to load session values(%s) from redis:
	the retrieved value is not a sessions.RemoteStore type, please report that as bug, it should never occur`,sid)
	return
}
// ...

Since the value store of session had already been serialized before setting:

func (db *Database) sync(p sessions.SyncPayload) {
	// ...
	storeB, err := p.Store.Serialize()
	if err != nil {
		golog.Error("error while encoding the remote session store")
		return
	}
        // ...
}

they should be decoded after read from redis:

// bad: storeDB, ok := storeMaybe.(sessions.RemoteStore)
storeDB, err = sessions.DecodeRemoteStore(storeMaybe.([]byte))
if err != nil {
// ...

[kataras]

@sy264115809 Correct, this should be left as it was because in the first place we tried to use another of redis feature to store the remote store as it is without custom encoding/decoding. I'll fix it right now but you can also make pull requests in the future, your bug reports are valid and welcomed, thank you for your contribution.

[sy264115809]

👍🏻