Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

hero: optimize *binding'String #2156

Merged
merged 1 commit into from Jun 22, 2023
Merged

hero: optimize *binding'String #2156

merged 1 commit into from Jun 22, 2023

Conversation

callthingsoff
Copy link
Contributor

For faster execution,
use strconv.Itoa rather than fmt.Sprintf to convert an integer to string,
remove if statement in loop.

@callthingsoff
hero: optimize *binding'String
7fb0091 
For faster execution,
use strconv.Itoa rather than fmt.Sprintf to convert an integer to string,
remove if statement in loop.
@CLAassistant
Copy link

CLAassistant commented Jun 14, 2023 •
edited

CLA assistant check
All committers have signed the CLA.

kataras
kataras approved these changes Jun 22, 2023
View reviewed changes
Copy link
Owner

@kataras kataras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @gocurr, the .String method there does not affect the performance, it's not used anywhere except debug logging but it's nice you catch it. Approved

@kataras kataras merged commit 4c04a80 into kataras:master Jun 22, 2023
3 checks passed
@callthingsoff callthingsoff deleted the binding_string branch June 23, 2023 01:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kataras kataras kataras approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@callthingsoff @CLAassistant @kataras