Fix up for sessions #693
Merged
Fix up for sessions #693
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Restore expiration state of the sessions - Add APIs to modify expire date - Free the timer for the session destroy task
|
Hello @corebreaker I just came back from the office, it looks very promising, nice job again! Can I ask you to update the sessions examples, and here where ever is needed too? |
|
I changed examples on iris-contrib too but Travis failed cause new methods implemented in this PR have not been available yet for iris-contrib. |
kataras
approved these changes
Aug 1, 2017
WingGao
pushed a commit
to WingGao/iris
that referenced
this pull request
Oct 9, 2020
Fix up for sessions Former-commit-id: 12b18902b4776335053b4d971ec564a9659a4c2d
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes up issue #692 .
What this PR adds: