New flag: no-color
#52
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
katbyte
reviewed
Mar 8, 2022
cli/cmds.go
Outdated
| @@ -227,6 +227,7 @@ func Make() *cobra.Command { | |||
| pflags.BoolP("check", "c", false, "return an error during diff if formatting is required") | |||
| pflags.BoolP("verbose", "v", false, "show files as they are processed& additional stats") | |||
| pflags.BoolP("quiet", "q", false, "quiet mode, only shows block line numbers ") | |||
| pflags.BoolP("no-color", "C", false, "disable colorful output") | |||
There was a problem hiding this comment.
could we change this to
Suggested change
| pflags.BoolP("no-color", "C", false, "disable colorful output") | |
| pflags.BoolP("uncoloured", "u", false, "disable coloured output") |
There was a problem hiding this comment.
@katbyte Sure, made the change.
katbyte
approved these changes
Mar 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support
no-colorflag to suppress colorful output. This is useful when combiningterrafmtwith other tools via pipe. My use case is to combineterrafmt blockstogether with https://github.com/magodo/hclgrep to filter certain pattern among acctests.