Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating to use Go 1.18 / github.com/hashicorp/hc-install #54

Merged
merged 3 commits into from
Mar 21, 2022

Conversation

tombuildsstuff
Copy link
Contributor

@tombuildsstuff tombuildsstuff commented Mar 21, 2022

This PR does three things:

  1. Updates the Go mod file to use Go 1.18
  2. Updates the dependencies to account for that ^ - and also removes the vendor folder, since this shouldn't be committed for a library
  3. Switches the installer to using github.com/hashicorp/hc-install as tfinstall is no longer supported/available.

Unfortunately since there is no 0.12.x binary for Apple Silicon, I'm unable to run the tests for this - I looked into upgrading to Terraform 1.x but that appears outside the scope of this PR initially.

Due to item 2 above, I'd recommend reviewing this commit-by-commit.

Unblocks hashicorp/terraform-provider-azurerm#15902

Switches the installer to using `github.com/hashicorp/hc-install` as `tfinstall` is no longer supported/available.
Copy link
Owner

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🏗️

@katbyte katbyte added this to the v0.3.0 milestone Mar 21, 2022
@katbyte katbyte merged commit 70b08ed into katbyte:main Mar 21, 2022
@tombuildsstuff tombuildsstuff deleted the f/1.18 branch March 21, 2022 17:56
@katbyte katbyte modified the milestones: v0.3.0, v0.4.0 Mar 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants