Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds support for format verbs as parameters #58

Merged
merged 3 commits into from
Aug 3, 2022
Merged

Adds support for format verbs as parameters #58

merged 3 commits into from
Aug 3, 2022

Conversation

gdavison
Copy link
Contributor

Using format verbs as a Terraform parameter, such as

resource "aws_efs_file_system" "test" {
  lifecycle_policy {
    %s = %q
  }
}

causes HCL parsing to fail.

Closes #47

Includes #57

katbyte
katbyte approved these changes Aug 3, 2022
View reviewed changes
Copy link
Owner

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🌻

@katbyte katbyte added this to the v0.5.0 milestone Aug 3, 2022
@katbyte katbyte merged commit b7a8d42 into katbyte:main Aug 3, 2022
katbyte added a commit that referenced this pull request Aug 3, 2022
@katbyte
CHANGELOG #58
65c2bfd
@gdavison gdavison deleted the support-fmtverbs-as-parameters branch August 4, 2022 22:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@katbyte katbyte katbyte approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.5.0
Development

Successfully merging this pull request may close these issues.

Format verbs for parameter names fail to parse as HCL
2 participants
@gdavison @katbyte