Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow capital letters to resource name on block reader #71

Merged
merged 1 commit into from
Aug 16, 2022

Conversation

jeremmfr
Copy link
Contributor

Uppercase letters in the resource name are allowed but the block reader doesn't detect the block in this case.

The merge of MR #56 has been reverted by MR #67, so I recreate the same fix of #56 but with unit tests to avoid losing this fix again.

Copy link
Owner

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whoops sorry about that @jeremmfr - thanks for reopening a PR to fix this LGTM 🔒

@katbyte katbyte added this to the v0.5.2 milestone Aug 16, 2022
@katbyte katbyte merged commit 093e0a3 into katbyte:main Aug 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants