Remove "exit" [1/n] (from output functions). #40
Conversation
|
Hi Kate, Note that I used You might want to remove them (please let me know). They are very useful. You might want to keep them, or put them behind a macro. Maybe this one: |
|
Thank you for this! This is great. I'm fine with introducing Thanks! |
ArthurSonzogni
force-pushed
the
issue-38
branch
from
269f609
to
e1c5fd5
Compare
|
I am back from a long week. |
|
Thank you! I think you forgot to add |
Using `exit(EXIT_FAILURE)` in the middle of a function makes kgt hard to be embedded as a library, because it interrupt the caller. This patch removes them in all the generators. This is replaced by returning the status (a boolean) to the caller. The caller will be a good position to decide what to do with the error. Issue: katef#38
ArthurSonzogni
force-pushed
the
issue-38
branch
from
e1c5fd5
to
2e00777
Compare
Indeed, I forgot. |
|
Thanks again! |
Using exit(EXIT_FAILURE) in the middle of a function makes kgt hard to be embedded as a library, because it interrupts the caller. The previous patch removed usage of exit for every generators: katef#40 This one removes usage of exit for every parser. The parsing_error struct is introduced to list all the errors. Issue: - katef#38 - ArthurSonzogni/Diagon#19
Using exit(EXIT_FAILURE) in the middle of a function makes kgt hard to be embedded as a library, because it interrupts the caller. The previous patch removed usage of exit for every generators: katef#40 This one removes usage of exit for every parser. The parsing_error struct is introduced to list all the errors. Issue: - katef#38 - ArthurSonzogni/Diagon#19
Using exit(EXIT_FAILURE) in the middle of a function makes kgt hard to be embedded as a library, because it interrupts the caller. The previous patch removed usage of exit for every generators: katef#40 This one removes usage of exit for every parser. The parsing_error struct is introduced to list all the errors. Issue: - katef#38 - ArthurSonzogni/Diagon#19
Using exit(EXIT_FAILURE) in the middle of a function makes kgt hard to be embedded as a library, because it interrupts the caller. The previous patch removed usage of exit for every generators: katef#40 This one removes usage of exit for every parser. The parsing_error struct is introduced to list all the errors. Issue: - katef#38 - ArthurSonzogni/Diagon#19
Using exit(EXIT_FAILURE) in the middle of a function makes kgt hard to be embedded as a library, because it interrupts the caller. The previous patch removed usage of exit for every generators: #40 This one removes usage of exit for every parser. The parsing_error struct is introduced to list all the errors. Issue: - #38 - ArthurSonzogni/Diagon#19
Using
exit(EXIT_FAILURE)in the middle of a function makes kgt hard tobe embedded as a library, because it interrupt the caller.
This patch removes them in all the generators. This is replaced by
returning the status (a boolean) to the caller. The caller will be a
good position to decide what to do with the error.
Issue:
#38