Add fsm_print_vmc mode to fuzzer.
#410
Conversation
While on an older branch I got some warnings for uninitialized memory in src/libfsm/vm/ir.c's `initial_translate_state` (for `st->strategy`). The issue seems to have been fixed already on `main`, but I added a fuzz harness to search for inputs that triggered `abort()`/assert. I ran it for about an hour without finding any, but it's probably worth keeping the fuzzer code.
|
Rerunning CI, unrelated failures due to network errors in the documentation jobs. |
| } | ||
|
|
||
| /* see if this triggers any asserts */ | ||
| fsm_print_vmc(f, fsm); |
There was a problem hiding this comment.
I think we should call all fsm_print interfaces here. This fuzzer isn't really specific to the VM-based outputs, either. Let's run everything we have.
There was a problem hiding this comment.
Doing so immediately revealed that several of them assert or exit(EXIT_FAILURE) if called with an unsupported IO mode. Should they just return instead?
There was a problem hiding this comment.
Oh, no. That's part of their calling contract. I think really we should have them return -1 for failure (which they should be doing anyway, but aren't), and set ENOTSUPP. I'll take that on a separate PR, i want to bubble up other errors through that interface for e.g. when fprintf fails. Thanks!
There was a problem hiding this comment.
Okay. I can commit calling all of them that but not my local changes to make them not exit/assert, then.
While on an older branch I got some warnings for uninitialized memory in src/libfsm/vm/ir.c's
initial_translate_state(forst->strategy). The issue seems to have been fixed already onmain, but I added a fuzz harness to search for inputs that triggeredabort()/assert.I ran it for about an hour without finding any, but it's probably worth keeping the fuzzer code.