Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add error code for unsupported PCRE cases (RE_EUNSUPPPCRE), reject one. #447

Merged
merged 4 commits into from
Jan 11, 2024

Commits on Oct 19, 2023

  1. Add error code for unsupported PCRE cases (RE_EUNSUPPPCRE), reject one.

    There's extra error codes in #440 for regexes that aren't UNSATISFIABLE
    per se, but depend on particular corner cases in PCRE that probably
    aren't worth supporting in an automata-based implementation.
    
    Add a test case for one, tests/pcre/in48.re: ^a|$[^x]b*
    
    This is a tricky one to handle properly; according to PCRE it should
    match either "a<anything...>" OR "\n", but nothing else. The newline
    match is because $ is a non-input-consuming check that evaluation is
    either at the end of input, or at a newline immediately before the end.
    In this case `$[^x]b*` matches exactly one newline; it's equivalent to
    "$\n". This probably isn't worth supporting, but we can detect cases
    where a potential newline match appears after a $ and reject them as
    an unsupported PCRE behavior.
    silentbicycle committed Oct 19, 2023
    Configuration menu
    Copy the full SHA
    928a696 View commit details
    Browse the repository at this point in the history

Commits on Jan 4, 2024

  1. Configuration menu
    Copy the full SHA
    9f1d072 View commit details
    Browse the repository at this point in the history

Commits on Jan 5, 2024

  1. Configuration menu
    Copy the full SHA
    16957a2 View commit details
    Browse the repository at this point in the history

Commits on Jan 8, 2024

  1. ast_analysis.c: Add assert for unreachable branch.

    Ranges using named endpoints are currently rejected with "Unsupported
    operator".
    silentbicycle committed Jan 8, 2024
    Configuration menu
    Copy the full SHA
    f5b1300 View commit details
    Browse the repository at this point in the history