New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix node-tests
#272
Fix node-tests
#272
Conversation
Without these the tests aren't running properly
`ember-cli-eslint` was generating failing tests, which we don't care about in our test suite
there were several issues with the TS tests. after fixing some of them I gave up. the latest issue was complaining about a missing babel dependency somewhere. |
@lifeart are you able to take a look? I don't use TS anywhere, so I am unfamiliar with what we need to do here. |
TS is working fine. I don鈥檛 understand why TS tests was removed, even if they not running. Hope to check on it in next month. |
@rwwagner90 tests not working, but coverage for ts working fine (in my understanding) |
@lifeart the tests not working implies to me TS doesn't work either, but again, I don't know about TS, so we need to poke at the master branch. |
Closes #264
Unfortunately I had to completely remove the TypeScript tests since they were not working at all 馃し
/cc @rwjblue