Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix node-tests #272

Merged
merged 7 commits into from Aug 29, 2020
Merged

Fix node-tests #272

merged 7 commits into from Aug 29, 2020

Conversation

Turbo87
Copy link
Collaborator

@Turbo87 Turbo87 commented Aug 23, 2020

Closes #264

Unfortunately I had to completely remove the TypeScript tests since they were not working at all 馃し

/cc @rwjblue

`ember-cli-eslint` was generating failing tests, which we don't care about in our test suite
@Turbo87 Turbo87 changed the title WIP: Fix node-tests Fix node-tests Aug 23, 2020
@RobbieTheWagner
Copy link
Collaborator

Hmm, I wonder why TS isn't working. @rwjblue any ideas? Thanks for fixing all these tests @Turbo87!

@Turbo87
Copy link
Collaborator Author

Turbo87 commented Aug 23, 2020

there were several issues with the TS tests. after fixing some of them I gave up. the latest issue was complaining about a missing babel dependency somewhere.

@Turbo87
Copy link
Collaborator Author

Turbo87 commented Aug 29, 2020

merging this for now to unblock further work on this addon.

@lifeart @rwwagner90 since #223 broke this and added TS support in the same PR it would be good if you could have a look at adding correctly working tests for this feature again to prevent it from breaking in the future.

@Turbo87 Turbo87 merged commit 6977e05 into ember-cli-code-coverage:master Aug 29, 2020
@Turbo87 Turbo87 deleted the tests branch August 29, 2020 18:55
@RobbieTheWagner
Copy link
Collaborator

@lifeart are you able to take a look? I don't use TS anywhere, so I am unfamiliar with what we need to do here.

@lifeart
Copy link
Contributor

lifeart commented Aug 31, 2020

TS is working fine.

I don鈥檛 understand why TS tests was removed, even if they not running.

Hope to check on it in next month.

@RobbieTheWagner
Copy link
Collaborator

@lifeart what do you mean by it's working? I believe @Turbo87 is saying with these changes TS no longer works or at least the tests don't. We need some tweaks to get things working again on master.

@lifeart
Copy link
Contributor

lifeart commented Aug 31, 2020

@rwwagner90 tests not working, but coverage for ts working fine (in my understanding)

@RobbieTheWagner
Copy link
Collaborator

@lifeart the tests not working implies to me TS doesn't work either, but again, I don't know about TS, so we need to poke at the master branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants