Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Properties to configure default katharsis paging behavior #264

Open
Ramblurr opened this issue Dec 16, 2016 · 1 comment
Open

Properties to configure default katharsis paging behavior #264

Ramblurr opened this issue Dec 16, 2016 · 1 comment
Assignees
@Ramblurr
Labels
enhancement

Comments

@Ramblurr
Copy link
Contributor

I would like to see some properties to configure the default katharsis-jpa behavior:

  • default-page-limit: control the default page limit for queries where no page[limit] param was passed
  • max-page-size: control the maximum number of elements allowed in a page

These are important for preventing Denial-of-Service attacks.
@remmeier
Copy link
Contributor

Dault Page Limit is available on the queryspecdeserializer. Max Limit is a good idea. Maybe both could be set with the existing properties mechanisms.

I think it is a more general issue for any Kind of repo.

@Ramblurr Ramblurr self-assigned this Dec 16, 2016
@Ramblurr Ramblurr changed the title Properties to configure default katharsis-jpa paging behavior Properties to configure default katharsis paging behavior Dec 16, 2016
Ramblurr pushed a commit that referenced this issue Dec 16, 2016
#264 Properties to configure default katharsis paging behavior
3b8dd43 
* adds max-page-limit property
* cleans up documentation for spring boot properties configuration
Ramblurr pushed a commit that referenced this issue Dec 16, 2016
#264 Properties to configure default katharsis paging behavior
611ea17 
* adds max-page-limit property
* cleans up documentation for spring boot properties configuration
Ramblurr pushed a commit that referenced this issue Dec 16, 2016
#264 Properties to configure default katharsis paging behavior
e3123e7 
* adds max-page-limit property
* cleans up documentation for spring boot properties configuration
Ramblurr pushed a commit that referenced this issue Dec 16, 2016
#264 Properties to configure default katharsis paging behavior
1c39afb 
* adds max-page-limit property
* cleans up documentation for spring boot properties configuration
masterspambot pushed a commit that referenced this issue Dec 23, 2016
@Ramblurr @masterspambot
#264 Properties to configure default katharsis paging behavior (#265)
11bf32c 
* * adds max-page-limit property
* cleans up documentation for spring boot properties configuration

* Increase code coverage
@masterspambot masterspambot mentioned this issue Jul 29, 2016
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Ramblurr Ramblurr

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Ramblurr @remmeier