Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Includes section of API response stopped showing nested data when include parameters increased #29

Closed
masterspambot opened this issue Jul 29, 2016 · 4 comments

Comments

@masterspambot
Copy link
Member

From @srajeev on May 10, 2016 15:57

An API that was working for us stopped including a nested relationship's include in the "Included" section of response after we added 6 new include parameters.

I will use an example similar to our use case to explain the issue:

ManagerResource has a UserResource include. UserResource has an AddressResource. The URL include param was.../manager?include=["user", "user.address"]. This was returning user and address in the included section of the response. But when we added more include params, it stopped returning include relations that are nested one level down. In this case, address stopped showing up in response.

Are there any known limitations or issues with includes of nested objects in Katharsis?

We are on version 0.9.4

Thanks
Shyla

Copied from original issue: katharsis-project/katharsis-core#308

@masterspambot
Copy link
Member Author

From @meshuga on May 10, 2016 20:2

Is it possible to update to a never version e.g 2.4.0? The inclusion mechanism changed a lot since the last summer where 0.9.4 was released.

@masterspambot
Copy link
Member Author

From @srajeev on May 11, 2016 18:1

We can't do that now, as we have some front end heavily used applications using this response. Last time when we looked, we were concerned about the JSON representation changes after 0.9.4.. causing a lot of refactoring needed in our front end application. So, can't do that now, as we need to prioritize this effort.
As a work around, we flattened the second level fields to the first level. But was wondering what was causing this. It almost seems like, there is a limit of include params, causing this cut off after a s=certain number. Are you aware about any similar issues in 0.9.4?

Thanks
Shyla

@masterspambot
Copy link
Member Author

As till v1.0.0 we weren't covering JSON-API standard and were heavily developing library itself, so it's hard to say and respond easily to your issue as most of the users are v1/v2.

@masterspambot
Copy link
Member Author

@srajeev As for now we can not support solving this issue, but if you'd like to get extensive support with migrating to newest version of katharsis please contact us on support@katharsis.io and we can discuss the details.

@meshuga meshuga closed this as completed Aug 11, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants