-
Notifications
You must be signed in to change notification settings - Fork 180
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated README, remove duplicate Open Graph tags, SEO optimization, featured image and more #54
Open
sjbrg
wants to merge
10
commits into
kathyqian:master
Choose a base branch
from
sjbrg:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Commits on Jan 14, 2022
-
Configuration menu - View commit details
-
Copy full SHA for bfde5a8 - Browse repository at this point
Copy the full SHA bfde5a8View commit details -
Remove duplicate Open Graph tags
The tags og:title, og:type and og:description are populated by Ghost natively, so no need for the theme to do it.
Configuration menu - View commit details
-
Copy full SHA for a774c88 - Browse repository at this point
Copy the full SHA a774c88View commit details -
Changed so the site title H1 tag is only used on the homepage. On other pages / posts the site title is a span with identical styling, which gives more weight to the actual topic of the page that you likely want to rank for in search engines.
Configuration menu - View commit details
-
Copy full SHA for 15e3470 - Browse repository at this point
Copy the full SHA 15e3470View commit details -
Added support for theme internationalization, as well as swedish translation.
Configuration menu - View commit details
-
Copy full SHA for 73f7f68 - Browse repository at this point
Copy the full SHA 73f7f68View commit details -
I've broken out the post meta (date and tags) from the h3 title tag so that it only includes the actual post title. Best practice for SEO-purposes. Also added CSS to keep styling identical. On small screens the post meta is placed underneath the page title to avoid ugly line breaks.
Configuration menu - View commit details
-
Copy full SHA for b86ebc7 - Browse repository at this point
Copy the full SHA b86ebc7View commit details -
I'd suggest adding support for custom excerpt. One might think it takes away from the "minimalist"-approach of this theme, but even if it's supported you don't have to use it. And at least for me who have used custom excerpts with my previous theme this allowed me (and will help others) to take the jump and try out Crisp without loosing that content.
Configuration menu - View commit details
-
Copy full SHA for 0d8f7a4 - Browse repository at this point
Copy the full SHA 0d8f7a4View commit details -
For the same reason as suggesting support for custom excerpt is added, I would suggest support for featured images is added. I have featured images on most of my posts and when I switched to Crisp I "lost" those images. Adding support gives people the option to use it if they want. This featured image code is borrowed from the default Casper theme.
Configuration menu - View commit details
-
Copy full SHA for c96a595 - Browse repository at this point
Copy the full SHA c96a595View commit details -
Change link color to use accent color variable
Replaced hardcoded link color with with the native accent color variable to use the accent color that's set in the Ghost design settings.
Configuration menu - View commit details
-
Copy full SHA for 8f52ddd - Browse repository at this point
Copy the full SHA 8f52dddView commit details
Commits on Jan 15, 2022
-
Ghost recommendation for internationalization
Updated to set lang code according to setting in Ghost settings.
Configuration menu - View commit details
-
Copy full SHA for d307b94 - Browse repository at this point
Copy the full SHA d307b94View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5723ae1 - Browse repository at this point
Copy the full SHA 5723ae1View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.