Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug(demo-app-playgound): Mobile --> isDragging chip does not change color while dragging #3

Closed
Achilles1515 opened this issue Feb 4, 2021 · 4 comments
Labels
bug Something isn't working

Comments

@Achilles1515
Copy link

Achilles1515 commented Feb 4, 2021

Title pretty much says it all.

Not sure if this is just iOS or specific to iOS 14 - haven't dug into any of the code yet.
EDIT: Is reproducible with Chrome simulating a mobile device.

Video demonstration:
GIF

@Achilles1515 Achilles1515 changed the title bug(demo-app-playgound): iOS 14 --> isDragging chip does not change color while dragging bug(demo-app-playgound): Mobile --> isDragging chip does not change color while dragging Feb 4, 2021
@llorenspujol llorenspujol added the bug Something isn't working label Feb 4, 2021
@llorenspujol
Copy link
Contributor

Thanks for the report! It also happens in my Android phone, I am quite curios on why this is happening. I will check it shortly.

@Achilles1515
Copy link
Author

Achilles1515 commented Feb 4, 2021

onDragStarted(event: KtdDragStart) {
      console.log(NgZone.isInAngularZone()); // outputs `true` on desktop, `false` on mobile
      this.isDragging = true;
    }

@llorenspujol
Copy link
Contributor

I see that touch event from dragStart$ is outside the zone (which is expected) but it never re-enters. dragStarted event should be always inside the zone by default, and with that returning always 'true' in your test.

Do you want to do a Merge request with de fix? @Achilles1515

Overall what needs to be done is ensure that the event dragStarted is inside the zone.

llorenspujol added a commit that referenced this issue Feb 5, 2021
…).

fix(grid-item): dragStart$ to be always outside the zone on mouse/touch move events.
@llorenspujol
Copy link
Contributor

I've fixed it since I want to include this bug solved into the next release with the scroll feature, here it is if you want to check: 51d7d76

Thank you:)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants