Merge c5ac3f0 into f8544de

CHANGES.md

@@ -4,6 +4,8 @@ wavesurfer.js changelog
 4.0.0 (21.06.2020)
 ------------------
 
+- Fixes for event handling with certain plugins (regions, microphone).
+  The crash would have involved '_disabledEventEmissions'
 - Fixed mediaelement-webaudio playback under Safari (#1964)
 - Fixed the `destroy` method of the `MediaElementWebAudio` backend. Instead of
   destroying only the media element, the audio nodes are disconnected and the

src/util/observer.js

@@ -115,14 +115,23 @@ export default class Observer {
         this._disabledEventEmissions = eventNames;
     }
 
+    /**
+     * plugins borrow part of this class without calling the constructor,
+     * so we have to be careful about _disabledEventEmissions
+     */
+
+    _isDisabledEventEmission(event) {
+        return this._disabledEventEmissions && this._disabledEventEmissions.includes(event);
+    }
+
     /**
      * Manually fire an event
      *
      * @param {string} event The event to fire manually
      * @param {...any} args The arguments with which to call the listeners
      */
     fireEvent(event, ...args) {
-        if (!this.handlers || this._disabledEventEmissions.includes(event)) {
+        if (!this.handlers || this._isDisabledEventEmission(event)) {
             return;
         }