Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bower "main" field cannot contain minified files #699

Closed
thijstriemstra opened this issue Apr 12, 2016 · 4 comments
Closed

bower "main" field cannot contain minified files #699

thijstriemstra opened this issue Apr 12, 2016 · 4 comments
Labels

Comments

@thijstriemstra
Copy link
Contributor

Seeing this error:

bower wavesurfer.js#>=1.0.57         invalid-meta The "main" field cannot contain minified files
bower wavesurfer.js#>=1.0.57             resolved https://github.com/katspaugh/wavesurfer.js.git#1.1.1
@chrisparton1991
Copy link
Contributor

I'm only a fledgling Bower user myself, but I suspect best practice is to provide non-minified versions as output to Bower, which gives consumers the option of minifying themselves using a Grunt/Gulp task etc.

I think the fix here is, as suggested by the error, to not minify/uglify the file in Grunt (although it may be possible to trick bower by not naming the file .min.js).

Thoughts, @katspaugh?

@katspaugh
Copy link
Owner

Yes, I guess we need to add a new, not minified, file in the distribution.

@katspaugh katspaugh added the bug label Apr 22, 2016
@Lingomat
Copy link

Yep, Aikuma's gulp file builds wavesurfer.js and has overridea in the bower package. Bit ugly, but no huge deal.

@katspaugh
Copy link
Owner

I've added the uniminified file to the build and updated the version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants