Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bower "main" field cannot contain minified files #488

Open
FizzBuzz791 opened this issue Mar 14, 2017 · 3 comments
Open

bower "main" field cannot contain minified files #488

FizzBuzz791 opened this issue Mar 14, 2017 · 3 comments

Comments

@FizzBuzz791
Copy link
Contributor

Appears that best practice (at-least for bower) is to provide the files in un-minified format and allow the end user to minify them along with their own files.

This issue; katspaugh/wavesurfer.js#699 covers it, as do the linked issues; victorb/ngProgress#119 and Packet-Clearing-House/maptable#11

Any chance we can get this fixed up?

@dfahlander
Copy link
Collaborator

I'm not that familiar with bower and would apprechiate some help regarding this. A PR for the master (and possibly master-1 branch) would help me much.

The bower.json is located at https://github.com/dfahlander/Dexie.js/blob/master/bower.json. For now its main attribute points out the minified dist version of the file. Also, I ignore source files.

@FizzBuzz791
Copy link
Contributor Author

I believe, based on the referenced issues, you just need to change the main options to use dexie.js instead of dexie.min.js and bower will stop complaining about invalid meta-data when people install it.

It explicitly says in the spec not to use minified files for the main option.

@FizzBuzz791
Copy link
Contributor Author

@dfahlander Now that it's merged, is there a chance of getting a release out? Would be 1.5.2 I think?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants