-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pre-generated json peaks array not loading #715
Comments
The problem was with the negative values generated by audiowaveform. I simply stripped them out of my peaks array and now we're in business. Here's an example of wavesurfer in production: |
Great that you figured it out. I actually thought negative peaks were not a problem. I'll mark this as a bug to add a |
Thanks for the confirmation. Love this library! |
Having a unit test for this would be nice! |
@mbordash how are you making to draw waveform with json data can you share some code ? |
Perhaps something like |
@katspaugh Yeah i find it and i got file like this http://collabshot.com/show/0T3kzy but when I am loading it with wavesurfer I think it creates incorrectly, see : http://collabshot.com/show/CovV4L wavesurfer.load('fifties_rock.mp3', result); |
@btomashvili I guess you also need to filter out negative values like the OP did. Oh yeah, and you need the |
thanks ;) |
Closing: inactive |
Hi,
I'm trying out your library to replace my own homegrown player based on audiowaveform. Upon upload, I'm generating json via audiowaveform so that I can pre-load the peaks in your player. Unfortunately, wavesurfer doesn't seem to like the json array range generated by audiowaveform (or more likely, I'm doing something boneheaded).
The generated json looks like this (snip):
[0,0,-12,7,-12,8,-14,15,-16,10,-11,13,-15,11, ... ]
Here's a test page with the array loaded at runtime
http://www.internetdj.com/test.html
Any tips? Many thanks in advanced.
Michael
The text was updated successfully, but these errors were encountered: