add bar height parameter #1020
Merged
add bar height parameter #1020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Awesome! Currently a higher value produces a larger waveform and a lower value a smaller one. Maybe we could change the name of the parameter, otherwise it will be confusing. (Something like |
|
@mspae ok I made it accept high values :P for example |
mspae
approved these changes
Mar 5, 2017
mspae
pushed a commit
to mspae/wavesurfer.js
that referenced
this pull request
Aug 19, 2017
* add barHeight parameter * Update drawer.multicanvas.js * Update drawer.canvas.js
mspae
pushed a commit
that referenced
this pull request
Aug 20, 2017
* add barHeight parameter * Update drawer.multicanvas.js * Update drawer.canvas.js
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add barHeight paramter, I'll update the docs once this gets merged.
#915 #944
example: http://codepen.io/entonbiba/pen/VpedWZ