set isMuted to false on load method #1045
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@katspaugh should I add this as an option to allow muting to continue even after loading new audio? |
|
That would logical too. If I mute wavesurfer object maybe I want it to be muted on new tracks too, until I unmute. |
|
Sure, let's add it. To me, it seems more logical to actually keep the next tracks muted by default since it's the same instance of the wavesurfer. But it's subjective. |
katspaugh
approved these changes
Mar 19, 2017
|
Merged, thanks! |
mspae
pushed a commit
to mspae/wavesurfer.js
that referenced
this pull request
Aug 18, 2017
mspae
pushed a commit
that referenced
this pull request
Aug 19, 2017
jonas2515
added a commit
to jonas2515/wavesurfer.js
that referenced
this pull request
Dec 11, 2017
* For the WebAudio backend muting already persists * For the MediaElement backend muting persists since 6b897c4
thijstriemstra
pushed a commit
that referenced
this pull request
Dec 22, 2017
…1268) * MediaElement backend: Update progress on pause events (#1267) * The progress might not get updated if the playback finishes while another tab is active * Fix it by updating the progress as soon as the playback is paused * MediaElement backend: Store volume between media changes * When loading a new audio file, the volume is reset to 1 because a new MediaElement is created * With the WebAudio backend the volume stays the same, this should also happen using the MediaElement backend * Revert "set isMuted to false on load method (#1045)" * For the WebAudio backend muting already persists * For the MediaElement backend muting persists since 6b897c4 * add changelog entry
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
set isMuted to false on new load
#1040