fixes safari browser missing buffer when using webaudio #1096
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
why are these values (1 channel, 4095 samples) hard coded? I guess Safari doesn't supply these values somewhere? |
|
@thijstriemstra yea that's the problem it doesn't. Safari TP should return the correct buffer, but it's a long way until that will be available. For now that's the best we can do to fix it in safari. |
katspaugh
reviewed
Jun 8, 2017
src/webaudio.js
Outdated
| @@ -223,6 +223,11 @@ WaveSurfer.WebAudio = { | |||
|
|
|||
| this.setLength(length); | |||
|
|
|||
| if (!this.buffer.length) { | |||
There was a problem hiding this comment.
Could you add a short comment regarding the Safari quirk?
There was a problem hiding this comment.
|
Thank you @entonbiba! |
mspae
pushed a commit
to mspae/wavesurfer.js
that referenced
this pull request
Aug 18, 2017
* fixes safari browser missing buffer when using webaudio * return correct buffer * set samples to 4096 * add safari comment
mspae
pushed a commit
that referenced
this pull request
Aug 19, 2017
* fixes safari browser missing buffer when using webaudio * return correct buffer * set samples to 4096 * add safari comment
@entonbiba can this workaround be removed yet? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #952 safari buffer undefined