Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrap drawing in requestAnimationFrame (multicanvas). #1106

Merged
merged 12 commits into from
Jun 11, 2017
Merged

Wrap drawing in requestAnimationFrame (multicanvas). #1106

Changes from 6 commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
ca217c6
Update drawer.multicanvas.js
agamemnus May 27, 2017
7d532a2
Update drawer.multicanvas.js
agamemnus May 27, 2017
621cf26
Update drawer.multicanvas.js
agamemnus May 27, 2017
0735e60
Update drawer.multicanvas.js
agamemnus May 27, 2017
4d64cef
I have no idea why this failed.
agamemnus May 27, 2017
219a2e3
Update drawer.multicanvas.js
agamemnus May 29, 2017
b926ebb
Update drawer.multicanvas.js
agamemnus May 29, 2017
9661b00
Update drawer.multicanvas.js
agamemnus May 29, 2017
38907ef
Merge branch 'master' into patch-8
thijstriemstra May 31, 2017
7bcf92a
Merge branch 'master' into patch-8
katspaugh Jun 1, 2017
3060ef8
Merge branch 'master' into patch-8
thijstriemstra Jun 8, 2017
196e300
Merge branch 'master' into patch-8
katspaugh Jun 11, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions src/drawer.multicanvas.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -139,7 +139,7 @@ WaveSurfer.util.extend(WaveSurfer.Drawer.MultiCanvas, {
}
},

drawBars: function (peaks, channelIndex, start, end) {
drawBars: utils.frame(function(peaks, channelIndex, start, end) {
// Split channels
if (peaks[0] instanceof Array) {
var channels = peaks;
Expand Down Expand Up @@ -231,15 +231,15 @@ WaveSurfer.util.extend(WaveSurfer.Drawer.MultiCanvas, {

// Always draw a median line
this.fillRect(0, halfH + offsetY - this.halfPixel, this.width, this.halfPixel);
},
}),

drawLine: function (peaks, absmax, halfH, offsetY, start, end) {
drawLine: utils.frame(function(peaks, absmax, halfH, offsetY, start, end) {
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utils is undefined. It has to be WaveSurfer.util. Please also restore the spaces after the function keyword.

this.canvases.forEach (function (entry) {
this.setFillStyles(entry);
this.drawLineToContext(entry, entry.waveCtx, peaks, absmax, halfH, offsetY, start, end);
this.drawLineToContext(entry, entry.progressCtx, peaks, absmax, halfH, offsetY, start, end);
}, this);
},
}),

drawLineToContext: function (entry, ctx, peaks, absmax, halfH, offsetY, start, end) {
if (!ctx) { return; }
Expand Down