Add pointerEvents: none to left/right sides. #1112
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hange zIndex to 3. The reasoning behind this is to allow, for example, the region plugin to have a styling such that the regions are below the waves (so that the waves look clearer and not blended with the regions), while still allowing resize events on the regions. Otherwise, the left/right sections of the wave block the resize elements of the regions, since their zIndex needs to be necessarily higher to be drawn over the regions.
|
Nice idea! |
katspaugh
approved these changes
Jun 8, 2017
|
@agamemnus can you also add this to the documentation? |
|
Ok, in a bit. By the way, what is the plan for merging changes into next? Are you just going to do a bunch of monster merges?
|
|
I'm not sure where I'd add it since it's not an option. |
glebm
reviewed
Jun 16, 2017
| @@ -72,11 +73,12 @@ WaveSurfer.util.extend(WaveSurfer.Drawer.MultiCanvas, { | |||
| entry.wave = this.wrapper.appendChild( | |||
| this.style(document.createElement('canvas'), { | |||
| position: 'absolute', | |||
| zIndex: 1, | |||
| zIndex: 2, | |||
There was a problem hiding this comment.
This makes it so that this canvas is above the progress wave (at least on Chrome), hiding it. See #1136
mspae
pushed a commit
to mspae/wavesurfer.js
that referenced
this pull request
Aug 18, 2017
* Remove pointer events from the left and right sides of the wave and change `zIndex` to 2. The reasoning behind this is to allow, for example, the region plugin to have a styling such that the regions are below the waves (so that the waves look clearer and not blended with the regions), while still allowing resize events on the regions. Otherwise, the left/right sections of the wave block the resize elements of the regions, since their `zIndex` needs to be necessarily higher to be drawn over the regions.
mspae
pushed a commit
that referenced
this pull request
Aug 19, 2017
* Remove pointer events from the left and right sides of the wave and change `zIndex` to 2. The reasoning behind this is to allow, for example, the region plugin to have a styling such that the regions are below the waves (so that the waves look clearer and not blended with the regions), while still allowing resize events on the regions. Otherwise, the left/right sections of the wave block the resize elements of the regions, since their `zIndex` needs to be necessarily higher to be drawn over the regions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without this change, if the zIndex of the waves is higher than the zIndex of the regions, the waves will stand out better but block the resize controls.
(Figured out how to do two files at once.)