Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code formatting (and linting) in precommit hook #1216

Merged
merged 2 commits into from
Oct 3, 2017

Conversation

mspae
Copy link
Contributor

@mspae mspae commented Sep 30, 2017

Short description of changes:

  • This PR contains no functional change to the library itself.
  • Adds prettier for consistent formatting
  • Eslint config was adjusted to check for correct formatting
  • Added Precommit hook to autoformat (and lint) code before it enters the repo (as detailed here)

Breaking in the external API:

/

Breaking changes in the internal API:

/

Todos/Notes:

No further configuration is needed to get the hook working. Simply check out this code and npm install – All future code will be formatted and linted before it is commited. (It will also fail to commit if there are linting issues)

@mspae mspae mentioned this pull request Sep 30, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants