regions plugin: allow drawing new regions over old ones, when the old ones are not resizable and not draggable #1633
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…draggable/resizable
thijstriemstra
changed the title
thijstriemstra
suggested changes
Apr 25, 2019
|
@thijstriemstra it's done. |
thijstriemstra
approved these changes
Apr 28, 2019
sandiz
pushed a commit
to sandiz/wavesurfer.js
that referenced
this pull request
May 21, 2019
… ones are not resizable and not draggable (katspaugh#1633) * Enable drawing regions over regions, if the underlying region is not draggable/resizable * Better documentation
sandiz
pushed a commit
to sandiz/wavesurfer.js
that referenced
this pull request
May 21, 2019
… ones are not resizable and not draggable (katspaugh#1633) * Enable drawing regions over regions, if the underlying region is not draggable/resizable * Better documentation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short description of changes:
When a region is not resizable and not draggable, I don't want to stop the event propagation, because the event is not handled. In this case, it makes it impossible to draw new regions over (maybe fixed background regions). With this PR, the event propagation only stops, if the region is resizable or draggable and actually handles the event.
Breaking in the external API:
None
Breaking changes in the internal API:
None
Todos/Notes:
None
Related Issues and other PRs:
None