Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

plugins: restore elan-wave-segment plugin #1756

Closed
wants to merge 2 commits into from

Conversation

thijstriemstra
Copy link
Contributor

fixes #1745

@coveralls
Copy link

Coverage Status

Coverage increased (+1.3%) to 80.984% when pulling 06b8607 on elan-wave-1745 into 8ba3328 on master.

@katspaugh
Copy link
Owner

@thijstriemstra is this blocked in some way?

A general note: I think the elan plugin and this segment plugin are both cool little apps in their own right, and they don't have to be plugins. They aren't really modifying wavesurfer.js in any way and can be built on top of it as regular apps.
Perhaps moving them to another repo would be a good idea.

@thijstriemstra
Copy link
Contributor Author

thijstriemstra commented Mar 11, 2023

is this blocked in some way?

yea; the actual work of bringing it back is blocking it ;)

Perhaps moving them to another repo would be a good idea.

fine with me.

@katspaugh
Copy link
Owner

yea; the actual work of bringing it back is blocking it ;)

Can you elaborate? Does the plugin code need to be updated because of the latest updates in wavesurfer.js?

If you're not planning to work on it, let's close the PR.

@thijstriemstra
Copy link
Contributor Author

The plugin was removed in v2 or v3, can't remember exact version. Not sure why it was removed, I guess it was too much work to refactor the plugin for latest wavesurfer/es6, see #1092 (comment)

If you're not planning to work on it, let's close the PR.

Agreed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Plugin elan-wave-segment.js is missing
3 participants