Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

timeline plugin: fix negative offset rendering #2470

Merged
merged 3 commits into from
Mar 4, 2022
Merged

timeline plugin: fix negative offset rendering #2470

merged 3 commits into from
Mar 4, 2022

Conversation

othmar52
Copy link
Contributor

@othmar52 othmar52 commented Mar 4, 2022 •
edited by thijstriemstra

Short description of changes:

when using negative values as timeline.options.offset the timeline is now rendered from start to the very end.
before that change the timeline for those seconds of negative offset had not been rendered at the end of the waveform

Related Issues and other PRs:

fixes #2463

thijstriemstra
thijstriemstra suggested changes Mar 4, 2022
View reviewed changes
Copy link
Contributor

@thijstriemstra thijstriemstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks! Can you also add a changelog entry (6.0.4)?

@thijstriemstra thijstriemstra changed the title timeline plugin: negative offset rendering issue timeline plugin: fix negative offset rendering Mar 4, 2022
@coveralls
Copy link

coveralls commented Mar 4, 2022 •
edited

Coverage Status

Coverage remained the same at 81.653% when pulling 58c4c72 on othmar52:2463-timeline-plugin-negative-offset-rendering-issue into 8d33268 on katspaugh:master.

thijstriemstra
thijstriemstra approved these changes Mar 4, 2022
View reviewed changes
Copy link
Contributor

@thijstriemstra thijstriemstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks.

@thijstriemstra thijstriemstra merged commit 5af6502 into katspaugh:master Mar 4, 2022
@othmar52
Copy link
Contributor Author

othmar52 commented Mar 5, 2022

youre welcome!
sorry for the typo - i will pay more attention next time i contribute to wavesurfer

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thijstriemstra thijstriemstra thijstriemstra approved these changes

Assignees
No one assigned
Labels
plugins
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

timeline plugin: negative offset rendering issue
3 participants
@othmar52 @coveralls @thijstriemstra