Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

spectrogram plugin: Add frequencyMin, frequencyMax scaling option #2471

Merged
merged 3 commits into from
Mar 5, 2022

Conversation

dofuuz
Copy link
Contributor

@dofuuz dofuuz commented Mar 5, 2022

Short description of changes:

Spectrogram plugin:

image

Breaking in the external API:

None.

Breaking changes in the internal API:

None.

Todos/Notes:

None.

Related Issues and other PRs:

#2424
fixes #2455

…e frequency axis.

- Set default 12kHz range to draw spectrogram like 5.x (katspaugh#2455)
Copy link
Contributor

@thijstriemstra thijstriemstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you also add a description of these options to the spectrogram example's documentation?

@coveralls
Copy link

coveralls commented Mar 5, 2022

Coverage Status

Coverage remained the same at 81.653% when pulling bfd79af on dofuuz:specgram-scale into 5af6502 on katspaugh:master.

- Add frequencyMin, frequencyMax, splitChannels
@thijstriemstra thijstriemstra merged commit 502ac42 into katspaugh:master Mar 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Spectrogram looks different between wavesurfer.js 5.2.0 and wavesurfer.js 6.0.1
3 participants