Feat: custom render function #2819
Conversation
Custom render function
Deploying with
|
| Latest commit: |
7fa4dab
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://9d187782.wavesurfer-js.pages.dev |
| Branch Preview URL: | https://custom-render.wavesurfer-js.pages.dev |
| const halfHeight = height / 2 | ||
| // Custom rendering function | ||
| if (options.renderFunction) { | ||
| options.renderFunction(channelData, ctx) |
There was a problem hiding this comment.
Random thoughtdrop:
Made me think that if might be beneficial to put everything from line 239 till the end of the method into some sort of defaultRenderFunctionFactory(name needs some work 😆 ), decoupled from the renderer module context.
As a sort of default rendering function factory to do something like:
...
renderFunction: defaultRenderFunctionFactory(barCustomizationOptions)
...
where defaultRenderFunctionFactory is:
const defaultRenderFunctionFactory = (channelData, context) => (options) => { ...render }
The reason i was thinking about it - i'm guessing a lot of custom rendering will be always "almost" the same, and having a very flexible "default" renderer will be beneficial; also will be easier to copy default and "change it" for lib users
There was a problem hiding this comment.
Not sure I follow.
We already expose a lot of options to customize the default rendering. If one wants something even more custom, they can write a custom function.
I've added a new option
renderFunction: (peaks, ctx) => voidwhich allows swapping out the default rendering function for a custom one.Resolves #2811