Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor: cache duration #2902

Merged
merged 1 commit into from
Jun 17, 2023
Merged

Refactor: cache duration #2902

merged 1 commit into from
Jun 17, 2023

Conversation

katspaugh
Copy link
Owner

As suggested in #2890, since audio duration is polled on every tick, it would be beneficial to cache it until another audio file is loaded.

@cloudflare-pages
Copy link

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: ad25891
Status: ✅  Deploy successful!
Preview URL: https://3bf16b0d.wavesurfer-js.pages.dev
Branch Preview URL: https://duration.wavesurfer-js.pages.dev

View logs

@github-actions
Copy link
Contributor

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 0 N/A
  • Result: ✅ success
  • Annotations: 0 total

Report generated by eslint-plus-action

@katspaugh katspaugh merged commit a62f2d6 into beta Jun 17, 2023
4 checks passed
@katspaugh katspaugh deleted the duration branch June 17, 2023 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant