Feat: Improve scroll position adjustments on zoom in/out #3518
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
katspaugh
approved these changes
Jan 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short description
The playhead position can drift a lot during zoom operations. Especially when zooming out when the playhead is at the end.
This PR improves the accuracy of the offset needed to
scrollLeftto keep the playhead visible. It does this by adding 1/2 pixel values to thescrollLeft(1/2 pixels is the level of precision supported with scrollbars)
Resolves #
Limits issue where playhead ends up off screen durning zoom operations.
Implementation details
How to test it
Using the Basic Zoom
Zoom out and set play head towards the end.
Zoom in to the play head
Then zoom out.
Note that the playhead is immediately lost on zoom out
Screenshots
With updates
https://github.com/katspaugh/wavesurfer.js/assets/47955954/f5ab9031-c080-45ab-995c-1a0ff3b5bf7c
Without updates
Broken.mov
Checklist